Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JULY CPU - JDK21 & JDK22 & JDK17 Updates For Shipping Linux Packages #964

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Jul 25, 2024

Updates required for JDK21 & JDK22 Alpine, Debian, RH & SUSE packages.

Also includes a bump for JDK17 / JRE17 to bump the spec version for some missing signatures.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@steelhead31
Copy link
Contributor Author

/merge

Copy link

Approval to merge during the lockdown cycle

Please can two Adoptium PMC members comment /approve?

@smlambert
Copy link
Contributor

/approve

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tricky to review every part of this in detail but I expect it's ok and we can correct if something goes wrong.
One comment though - are the changes to build.sh supposed to be in this PR? If so probably worth adding a comment into this PR mentioning it since it looks like a change in functionality.

@steelhead31
Copy link
Contributor Author

steelhead31 commented Jul 25, 2024

Tricky to review every part of this in detail but I expect it's ok and we can correct if something goes wrong. One comment though - are the changes to build.sh supposed to be in this PR? If so probably worth adding a comment into this PR mentioning it since it looks like a change in functionality.

Yes, I think this has already been merged, so actually went in with the changes for JDK8/11 as they were having the issues. , as per #961 ... now I've updated the branch, those changes have gone..

@steelhead31 steelhead31 requested a review from sxa July 25, 2024 11:57
@steelhead31 steelhead31 changed the title JULY CPU - JDK21 & JDK22 Updates For Shipping Linux Packages JULY CPU - JDK21 & JDK22 & JDK17 Updates For Shipping Linux Packages Jul 25, 2024
@steelhead31
Copy link
Contributor Author

Added a commit to allow a new push of JDK/JRE17 due to the issues with GPG signing yesterday, and a need to republish corrected binaries. ( raised in issue #962 ), but not present in every RPM based distribution.

@steelhead31
Copy link
Contributor Author

/approve

@github-actions github-actions bot dismissed their stale review July 25, 2024 13:22

Thank you @smlambert and @steelhead31 for your approvals, this pull request is now approved to merge during release.

@steelhead31 steelhead31 merged commit 0a9e70c into adoptium:master Jul 25, 2024
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants