Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace references of openjdk-systemtest with aqa-systemtest #132

Merged
merged 1 commit into from
May 12, 2021
Merged

Replace references of openjdk-systemtest with aqa-systemtest #132

merged 1 commit into from
May 12, 2021

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam force-pushed the remove-reference-of-openjdk-systemtest branch from a5acd69 to 7eb19c8 Compare May 10, 2021 18:30
@Mesbah-Alam
Copy link
Contributor Author

Hi @llxia , This pr is a replacement fo #129 - which didn't contain the latest changes that Keith had delivered to this Repo last week (hence the merge conflicts).

I ran a sanity check using the latest changes and it looks good: Grinder/15338

Could you please review?

@Mesbah-Alam Mesbah-Alam mentioned this pull request May 10, 2021
Closed
@Mesbah-Alam
Copy link
Contributor Author

Please note this PRs has to merged together with:
adoptium/aqa-tests#2542
adoptium/STF#115
adoptium/aqa-systemtest#425

@karianna karianna mentioned this pull request May 11, 2021
Merged
llxia
llxia approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from smlambert May 12, 2021 14:32
smlambert
smlambert approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit 9da0ed0 into adoptium:master May 12, 2021
@Mesbah-Alam Mesbah-Alam deleted the remove-reference-of-openjdk-systemtest branch May 12, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@llxia llxia llxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mesbah-Alam @smlambert @llxia