Add ED sign embedded trailing corner cases #133
Conversation
|
@fjeremic this almost ready for review. |
|
Looks good. @VermaSh could you fix the copyright? |
|
@fjeremic I have updated the copyright year but the test is still failing. Not sure if we need to update something or just need to rerun the test. |
openj9.test.daa/src/test.daa/net/openj9/test/decimals/TestPD2ED.java
Outdated
Show resolved
Hide resolved
Packed decimal to external decimal conversion corner cases:
- Max precision for preferred and alternate sign
- Non 0 packed decimal offset
- ending at the sign byte
- ending at non sign byte
Signed-off-by:Shubham Verma <[email protected]>
|
@fjeremic Copyright should be good now. |
|
@llxia any testing to launch here before we merge? |
|
@Mesbah-Alam could help to run Grinder to test these daa tests? Thanks |
|
Hi @fjeremic , TestPD2ED.java is part of daa2 load, which is exercised by DaaLoadTest_daa2_5m. Started a grinder for DaaLoadTest_daa2_5m using Shubham's branch here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/1059/console Please re-run this grinder to further test your changes, if needed. |
|
Grinder looks good and we've tested internally as well. Proceeding with the merge. Thanks all! |
Packed decimal to external decimal conversion corner cases:
Signed-off-by:Shubham Verma [email protected]