Add exhaustive packed decimal to external decimal percision tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VermaSh
changed the title
|
@fjeremic this is ready for review. I'll squash the commits once the changes are approved. |
fjeremic
approved these changes
Aug 23, 2021
Percisions 1 - 31 are tested through the `convertPackedDecimalToExternalDecimal` API for all 4 zoned decimal sign placements. Percisions are divided into two methods because having all 31 in one made the method too big for JIT inlining.
|
Yup, I ran these tests with and without JIT. |
VermaSh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.