Add resoning behind comparison to -0 and +0 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VermaSh
force-pushed
the
update_daa_tests
branch
from
5ef9f04 to
ebad70c
Compare
|
@joransiu / @r30shah, @Mesbah-Alam Can I please get a review? |
r30shah
reviewed
Apr 7, 2022
| @@ -2519,6 +2519,19 @@ public void testShiftLeftInvalidPrecision() | |||
| @Test | |||
| public void testLeftOffsetOne() | |||
| { | |||
| /* Both expectedArray and expectedArray2 are needed because | |||
There was a problem hiding this comment.
@VermaSh We do not need to quote PoPs here. I think if you elaborate on behavior difference from z14 and z15 here, it would be sufficient. (I think one of the updates you posted earlier on internal issue would be more suitable).
There was a problem hiding this comment.
I have replaced the quote with a summary explaining the behavior change.
|
@VermaSh: can you fix |
Signed-off-by: Shubham Verma <[email protected]>
VermaSh
force-pushed
the
update_daa_tests
branch
from
ebad70c to
54d777e
Compare
joransiu
approved these changes
Apr 12, 2022
|
@Mesbah-Alam this is ready to be merged |
|
I don't have merge rights in OpenJ9. @pshipton - could you please merge this? |
|
@Mesbah-Alam I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Verma [email protected]