-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace jdk8 OpenJ9 deprecated methods with equivalents #145
Conversation
@Mesbah-Alam pls take a look. |
Note that since standard API are used, the tests are no longer OpenJ9 specific and should run on Hotspot as well. |
Thanks for these changes @pshipton ! Looks like the grinder is still reproducing the original issue, e.g. https://openj9-jenkins.osuosl.org/job/Grinder_testList_0/117/consoleFull:
|
That's a new problem, but related. I'll fix and re-run. |
Otherwise the test code does not compile on jdk19 where the methods are removed. See eclipse-openj9/openj9#15127 Signed-off-by: Peter Shipton <[email protected]>
I just re-ran the failed tests, which are passing now. |
LGTM! (I don't have the right to approve or merge this PR). |
Otherwise the test code does not compile on jdk19 where the methods are
removed.
See eclipse-openj9/openj9#15127
See the compile problems in build https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-JDK19/68/
Tested in grinder https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/833