Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct shared library suffix on macOS #158

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Correct shared library suffix on macOS #158

merged 1 commit into from
Oct 2, 2024

Conversation

keithc-ca
Copy link
Contributor

@keithc-ca keithc-ca requested a review from pshipton October 2, 2024 17:58
@keithc-ca keithc-ca mentioned this pull request Oct 2, 2024
Merged
@karianna karianna merged commit 826f1fb into adoptium:master Oct 2, 2024
1 check passed
@keithc-ca keithc-ca deleted the dylib branch October 2, 2024 18:06
@pshipton
Copy link
Contributor

pshipton commented Oct 2, 2024

I'm not sure why we need this or what side affects it might have. There is no failure in the head stream.
https://openj9-jenkins.osuosl.org/job/Test_openjdk11_j9_extended.system_aarch64_mac_Release/86 is failing on the 0.48 release because eclipse-openj9/openj9#20202 isn't delivered there yet.

pshipton
pshipton reviewed Oct 2, 2024
View reviewed changes
...9.test.sharedClasses.jvmti/src/test.sharedClasses.jvmti/net/openj9/stf/SharedClassesAPI.java
String nativeExt;
if (PlatformFinder.isOSX()) {
nativeExt = ".dylib";
} else if (PlatformFinder.isWindows()) {
Copy link
Contributor

@pshipton pshipton Oct 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole block is inside !PlatformFinder.isWindows() so checking PlatformFinder.isWindows() doesn't seem useful.

@pshipton
Copy link
Contributor

pshipton commented Oct 2, 2024

This change breaks the test on Mac. I will revert it.
Agent library /Users/jenkins/workspace/Grinder/jvmtest/system/openj9-systemtest/openj9.test.sharedClasses.jvmti/bin/native/osx/libsharedClasses.dylib could not be opened (dlopen(/Users/jenkins/workspace/Grinder/jvmtest/system/openj9-systemtest/openj9.test.sharedClasses.jvmti/bin/native/osx/libsharedClasses.dylib, 1): image not found)

@pshipton pshipton mentioned this pull request Oct 2, 2024
Merged
@pshipton
Copy link
Contributor

pshipton commented Oct 2, 2024

Reverted via #159

@keithc-ca
Copy link
Contributor Author

This change was incomplete. I'll create a proper replacement shortly.

@pshipton
Copy link
Contributor

pshipton commented Oct 2, 2024

Pls make new changes as draft until they are tested.

@keithc-ca keithc-ca mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithc-ca @pshipton @karianna