Supersede local file over network download #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Davies
added
enhancement
sxa
approved these changes
Feb 8, 2021
There was a problem hiding this comment.
Certainly works for me so I'll approve (as expected, since it was in response to a concern I raised!) although we should possibly make it explicit in a comment to
PLATFORM_CONFIG_FILEPATH="$SCRIPT_DIR/platform-specific-configurations/${OPERATING_SYSTEM}.sh"
if [ ! -f "${PLATFORM_CONFIG_FILEPATH}" ]
to make it clear that if someone wants to auto-download to take effect then they are expected to delete the local ones from the clone - there is no way to force it to use downloaded ones instead of local ones.
* Local platform configs will now superceed network locations * Build will fail if a local file doesn't exist and PLATFORM_CONFIG_LOCATION is unset Signed-off-by: Morgan Davies <[email protected]>
M-Davies
force-pushed
the
local_superceed
branch
from
0e47dc7 to
9e6f34f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Morgan Davies [email protected]