-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required library for Configure to work on Ubuntu 22 onwards. ( for both Arm64 & x64 ) #3551
Conversation
Mac OS X failing GH is unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm not sure we want to be so restrictive here - we have multiple other architectures - can we use ${ARCHITECTURE}-linux-gnu
on the non-x64 ones? (Needs checking to see if the names match for the others - arm32 (probably not), ppc64le and s390x. RISC-V not currently relevant as we don't use our own compiler yet but I suspect that would be ok .
@sxa , architecture doesnt resolve quite right for x64, as the x86_64 value is over-ridden with x64, I can use "uname -m" which should work and match across the many architectures, and simplify that piece of logic, I'll make an appropriate change and test. |
VPC has completed ok with this change: https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=Ubuntu2204,label=vagrant/1812/console |
Yeah x64 will need a special case (hence my suggestion to try that on non-x64 which will still need the |
Extends the fix for #3547
On Ubuntu 22.04 onwards, the object files required for autoconf/configure are in a new path, due to a change relating to multiarch implementations in Ubuntu.
The new path required to be added to LIBRARY_PATH is : /usr/lib/x86_64-linux-gnu for x64
The new path required to be added to LIBRARY_PATH is : /usr/lib/aarch64-linux-gnu for arm64
In order to get configure to work, the new path is appended to the LIBRARY_PATH.