Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required library for Configure to work on Ubuntu 22 onwards. ( for both Arm64 & x64 ) #3551

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

steelhead31
Copy link
Contributor

Extends the fix for #3547

On Ubuntu 22.04 onwards, the object files required for autoconf/configure are in a new path, due to a change relating to multiarch implementations in Ubuntu.

The new path required to be added to LIBRARY_PATH is : /usr/lib/x86_64-linux-gnu for x64
The new path required to be added to LIBRARY_PATH is : /usr/lib/aarch64-linux-gnu for arm64

In order to get configure to work, the new path is appended to the LIBRARY_PATH.

@github-actions github-actions bot added aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS labels Nov 29, 2023
@steelhead31 steelhead31 marked this pull request as ready for review November 29, 2023 17:26
@karianna
Copy link
Contributor

Mac OS X failing GH is unrelated.

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, looks good

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm not sure we want to be so restrictive here - we have multiple other architectures - can we use ${ARCHITECTURE}-linux-gnu on the non-x64 ones? (Needs checking to see if the names match for the others - arm32 (probably not), ppc64le and s390x. RISC-V not currently relevant as we don't use our own compiler yet but I suspect that would be ok .

@steelhead31
Copy link
Contributor Author

Hmmm not sure we want to be so restrictive here - we have multiple other architectures - can we use ${ARCHITECTURE}-linux-gnu on the non-x64 ones? (Needs checking to see if the names match for the others - arm32 (probably not), ppc64le and s390x. RISC-V not currently relevant as we don't use our own compiler yet but I suspect that would be ok .

${ARCHITECTURE}-

@sxa , architecture doesnt resolve quite right for x64, as the x86_64 value is over-ridden with x64, I can use "uname -m" which should work and match across the many architectures, and simplify that piece of logic, I'll make an appropriate change and test.

@steelhead31
Copy link
Contributor Author

@steelhead31 steelhead31 requested a review from sxa November 30, 2023 12:09
@sxa
Copy link
Member

sxa commented Nov 30, 2023

@sxa , architecture doesnt resolve quite right for x64, as the x86_64 value is over-ridden with x64, I can use "uname -m" which should work and match across the many architectures, and simplify that piece of logic, I'll make an appropriate change and test.

Yeah x64 will need a special case (hence my suggestion to try that on non-x64 which will still need the if clause) but most of the others are probably ok :-) But I guess if uname -m is good enough everywhere that works too :-)

@steelhead31 steelhead31 merged commit 0d421da into adoptium:master Nov 30, 2023
21 of 22 checks passed
@steelhead31 steelhead31 deleted the fix_ubu22_arm64 branch November 30, 2023 12:25
@karianna karianna mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants