-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spelling: sign #3609
spelling: sign #3609
Conversation
Thank you for creating a pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
Signed-off-by: Josh Soref <[email protected]>
For the record, I have no idea why the bot labeled this w/ |
Good catch. Approved. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/thaw |
Pull Request unblocked - code freeze is over.
This job https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/425/consoleFull has this output:
And I'm fairly certain that the pattern here isn't doing what it's trying to do.
The code deals in regular expressions and
\s
is generally a whitespace character which would not matchs
.