Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spelling: sign #3609

Merged
merged 1 commit into from
Feb 6, 2024
Merged

spelling: sign #3609

merged 1 commit into from
Feb 6, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 12, 2024

This job https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/425/consoleFull has this output:

17:59:20 Build build-scripts » release » sign_temurin_gpg #26030 completed: SUCCESS

And I'm fairly certain that the pattern here isn't doing what it's trying to do.

The code deals in regular expressions and \s is generally a whitespace character which would not match s.

Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@github-actions github-actions bot added the aix Issues that affect or relate to the AIX OS label Jan 12, 2024
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Jan 12, 2024

For the record, I have no idea why the bot labeled this w/ aix

@adamfarley
Copy link
Contributor

Good catch. Approved. :)

Copy link
Contributor

@adamfarley adamfarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamfarley adamfarley enabled auto-merge (squash) January 12, 2024 13:42
@sxa
Copy link
Member

sxa commented Feb 6, 2024

/thaw

@github-actions github-actions bot dismissed their stale review February 6, 2024 16:58

Pull Request unblocked - code freeze is over.

@adamfarley adamfarley merged commit 0106cc2 into adoptium:master Feb 6, 2024
18 of 23 checks passed
@jsoref jsoref deleted the spelling-sign branch February 6, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aix Issues that affect or relate to the AIX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants