Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove C flags to disable warnings on JDK17 #3900

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 1, 2024

I recently completed the required backport work to compile JDK17u cleanly without the need for warnings to be disabled

Copy link

github-actions bot commented Aug 1, 2024

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Aug 1, 2024
@gdams gdams requested a review from andrew-m-leonard August 2, 2024 08:21
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@andrew-m-leonard
Copy link
Contributor

dragonwell11 I think is broken upstream...

@gdams gdams merged commit fa9e245 into adoptium:master Aug 2, 2024
27 of 28 checks passed
@gdams gdams deleted the warnings branch August 2, 2024 09:29
sophia-guo pushed a commit to sophia-guo/openjdk-build that referenced this pull request Aug 12, 2024
karianna pushed a commit that referenced this pull request Aug 12, 2024
* Add --cap-add SYS_PTRACE

* build: remove C flags to disable warnings on JDK17 (#3900)

* Bump actions/setup-java from 4.2.1 to 4.2.2 (#3904)

Bumps [actions/setup-java](https://github.com/actions/setup-java) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@99b8673...6a0805f)

---
updated-dependencies:
- dependency-name: actions/setup-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump github/codeql-action from 3.25.15 to 3.26.0 (#3906)

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.15 to 3.26.0.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@afb54ba...eb055d7)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Remove extra blank line

Signed-off-by: Sophia Guo <[email protected]>

---------

Signed-off-by: Sophia Guo <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: George Adams <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos Issues that affect or relate to the MAC OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants