Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reproducible tooling to select updated CDX 1.6 tools #4097

Merged
merged 3 commits into from
Dec 20, 2024

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Dec 20, 2024

Fixes #4096

CDX 1.6 spec deprecates metadata.tools, replaced by metadata.tools.components ToolInformation
https://github.com/adoptium/temurin-build/blob/master/tooling/release_download_test.sh also needs updating to download latest cyclonedx-cli to support CDX 1.6

Grinder: https://ci.adoptium.net/job/Grinder/12138/console

@andrew-m-leonard andrew-m-leonard self-assigned this Dec 20, 2024
@andrew-m-leonard andrew-m-leonard changed the title Update reproducible tooling to select updated CDX 1.0.6 tools Update reproducible tooling to select updated CDX 1.6 tools Dec 20, 2024
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that you will have tested that this fixes the problem and you're far more of an expert in this area than I am ;-)

Is there an opportunity here for docs on "What to change when you update the SBoM?". As another example, release_download_test.sh (called from the download_and_sbom_validation job) is another thing that might be impacted when people change the SBoM

Related (docs): #3860 (and maybe also the really old #957)

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@andrew-m-leonard andrew-m-leonard merged commit a53df22 into adoptium:master Dec 20, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducible test failure on Windows
3 participants