Secure key storage

[Christiantyemele]

No description provided.

[IngridPuppet]

I had a look at one of the failing tests:

──── STDERR:             did-endpoint web::tests::verify_didpop
thread 'web::tests::verify_didpop' panicked at crates/web-plugins/did-endpoint/src/plugin.rs:39:50:
Secrets Mastet_KEY env variable required: NotPresent

I ran a troubleshooting locally and can confirm that it is indeed because a MASTER_KEY env variable is not fed to the test. I am not fully aware of your current setup for setting those variables during tests, but make sure you're also setting this one your changes expect.

The other failure message also appears related to your changes introducing a call to a find_by_key method. Do you have that properly mocked?

 ──── STDERR:             did-endpoint didgen::tests::test_did_validation
thread 'didgen::tests::test_did_validation' panicked at crates/web-plugins/did-endpoint/src/didgen.rs:267:5:
MockKeystore::find_key_by(Document({"kid": String("did:peer:123#key-1")}), [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]): No matching expectation found

Overall, I have another question: are all tests consistently passing on your local environments in the team, or you just expect them to pass on the pipeline? I'm asking because I feel something got broken in the meantime.

[Christiantyemele]

I had a look at one of the failing tests:

──── STDERR:             did-endpoint web::tests::verify_didpop
thread 'web::tests::verify_didpop' panicked at crates/web-plugins/did-endpoint/src/plugin.rs:39:50:
Secrets Mastet_KEY env variable required: NotPresent

I ran a troubleshooting locally and can confirm that it is indeed because a MASTER_KEY env variable is not fed to the test. I am not fully aware of your current setup for setting those variables during tests, but make sure you're also setting this one your changes expect.

The other failure message also appears related to your changes introducing a call to a find_by_key method. Do you have that properly mocked?

 ──── STDERR:             did-endpoint didgen::tests::test_did_validation
thread 'didgen::tests::test_did_validation' panicked at crates/web-plugins/did-endpoint/src/didgen.rs:267:5:
MockKeystore::find_key_by(Document({"kid": String("did:peer:123#key-1")}), [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]): No matching expectation found

Overall, I have another question: are all tests consistently passing on your local environments in the team, or you just expect them to pass on the pipeline? I'm asking because I feel something got broken in the meantime.

the pipeline runs the tests with all the features enable while locally we run with the default features that's why cargo test might run locally and fail online because of some features

[IngridPuppet]

Do you mean to commit this file?

[Christiantyemele]

NO

[IngridPuppet]

Do you mean to commit this file?

[IngridPuppet]

Do you mean to commit this file?