14 implement mediation coordination workflow #18
+1,915
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndefokou
requested review from
IngridPuppet,
Hermann-Core,
Christiantyemele,
Blindspot22,
chendiblessing and
Tekum-Emmanuella
|
@Christiantyemele @IngridPuppet @Hermann-Core @Tekum-Emmanuella @Blindspot22 @chendiblessing Pleas review this PR |
Blindspot22
requested changes
Feb 3, 2025
|
|
||
| // Extract the body from the mediation response | ||
| const message: IMessage = mediation_response.as_value(); | ||
| // //Extract the body from the mediation response |
There was a problem hiding this comment.
Please what is the use of all this comments?
From line 35 - 48
If the implementations are no more needed, then they should be deprecated
| @@ -71,11 +83,23 @@ export async function pack_encrypt( | |||
| forward: true, | |||
| }, | |||
| ); | |||
| return result[0]; | |||
|
|
|||
| // let message = await wrap_in_forward.Message.wrap_in_forward( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Christiantyemele @IngridPuppet @Hermann-Core @Tekum-Emmanuella @Blindspot22 @chendiblessing Pleas review this PR