Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore unknown json properties from newer Keycloak versions #1266

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

bohmber
Copy link
Contributor

@bohmber bohmber commented Jan 29, 2025

keycloak-config-cli should work with future versions of Keycloak server

fixes #1265

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

keycloak-config-cli should work with future versions of Keycloak server

fixes adorsys#1265
keycloak-config-cli should work with future versions of Keycloak server

fixes adorsys#1265
@bohmber
Copy link
Contributor Author

bohmber commented Jan 30, 2025

Tested with the 26.0.5 version against Keycloak 26.1.0

keycloak-config-cli should work with future versions of Keycloak server

fixes adorsys#1265
@bohmber
Copy link
Contributor Author

bohmber commented Jan 30, 2025

@AssahBismarkabah can you review the PR, please?

@AssahBismarkabah AssahBismarkabah self-requested a review February 1, 2025 11:01
Copy link
Collaborator

@AssahBismarkabah AssahBismarkabah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with kc 26.1.0 LGTM @bohmber thanks.

@bohmber
Copy link
Contributor Author

bohmber commented Feb 1, 2025

@AssahBismarkabah can you merge the pr?

@AssahBismarkabah AssahBismarkabah merged commit 48e8a98 into adorsys:main Feb 1, 2025
17 checks passed
@bohmber bohmber deleted the feature/1265 branch February 1, 2025 17:54
@bohmber
Copy link
Contributor Author

bohmber commented Feb 1, 2025

@AssahBismarkabah thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keycloak-config-cli should work with future versions of Keycloak server
2 participants