openfortivpn 1.23.0 #1266
Merged
openfortivpn 1.23.0 #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md
Outdated
|
|
||
| * [-] Support older mac0S versions that lack vdprintf() | ||
| * [-] Patch certificate login error for FortiOS 7.4.4 | ||
| * [-] Fix size and initialisation for array `data` |
There was a problem hiding this comment.
Actually, I suggest you remove this line, because this PR reworks the code from the previous PR.
Suggested change
| * [-] Fix size and initialisation for array `data` |
There was a problem hiding this comment.
Sure, makes sense. Updated.
adrienverge
force-pushed
the
release/v1.23.0
branch
from
fef235b to
829acf3
Compare
adrienverge
commented
Feb 10, 2025
There was a problem hiding this comment.
I would just add #1267
Done 👌
Otherwise that's OK with me.
Thanks!
EDIT: Because of #1267, I also adapted:
* [-] Support older mac0S versions that lack vdprintf()
* [-] Patch certificate login error for FortiOS 7.4.4
-* [-] Clear otp after initial run
+* [-] Clear OTP after run
* [+] Support SAML login authentication
CHANGELOG.md
Outdated
|
|
||
| * [-] Support older mac0S versions that lack vdprintf() | ||
| * [-] Patch certificate login error for FortiOS 7.4.4 | ||
| * [-] Fix size and initialisation for array `data` |
There was a problem hiding this comment.
Sure, makes sense. Updated.
adrienverge
force-pushed
the
release/v1.23.0
branch
from
829acf3 to
ba251d0
Compare
adrienverge
force-pushed
the
release/v1.23.0
branch
from
ba251d0 to
e729d74
Compare
|
Fine by me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DimitriPapadopoulos @mrbaseman are you OK with this?
Would you prefer to include more changes in this release?
If not, are you OK with the changelog?
Thanks in advance!