Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an option to save RAM in the large calculation #43

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

BenjaminDbb
Copy link
Contributor

In many times, we need MPI to do massive calculations, therefore, there are LARGE result in the resultlist, leading to the memory leak. I add an option to disable record the resultlist.

Copy link
Owner

@adrn adrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - this seems like a good idea! I added some suggestions based on renaming the argument.

schwimmbad/mpi.py Outdated Show resolved Hide resolved
schwimmbad/mpi.py Outdated Show resolved Hide resolved
schwimmbad/mpi.py Outdated Show resolved Hide resolved
schwimmbad/mpi.py Outdated Show resolved Hide resolved
schwimmbad/mpi.py Outdated Show resolved Hide resolved
schwimmbad/mpi.py Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 60.046% when pulling 4c2006c on BenjaminDbb:BenjaminDbb-save-RAM into 8f3f520 on adrn:main.

@adrn adrn merged commit 1daf1b3 into adrn:main Aug 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants