Feature/rb5009 u pr+s+in update #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It took some time, but it's there.
I applied requested changes/reverts.
It shall do for rb5009 as well as for rb5009upr - the support for the latter is on my github/openwrt and added here as a patch https://forum.openwrt.org/t/add-support-for-mikrotik-rb5009ug/104391/1123?u=prudy.
If you merge it in, obviously the package Makefile needs git#/sha git link corrections.
For curiosity I noticed some more registers locations (voltage per port, total power, extra status code when on poe-in, as well as the confirmation i2s sequence seems be based on a key) - but those are not in since I had no time for adding this.