Fix:Server crash when updating media with external cover url that fai…

…ls to download #2857
advplyr · Apr 20, 2024 · f74d741 · f74d741
1 parent 15f8398
commit f74d741
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/server/controllers/LibraryItemController.js b/server/controllers/LibraryItemController.js
@@ -117,16 +117,20 @@ class LibraryItemController {
     zipHelpers.zipDirectoryPipe(libraryItemPath, filename, res)
   }
 
-  //
-  // PATCH: will create new authors & series if in payload
-  //
+  /**
+   * PATCH: /items/:id/media
+   * Update media for a library item. Will create new authors & series when necessary
+   * 
+   * @param {import('express').Request} req 
+   * @param {import('express').Response} res 
+   */
   async updateMedia(req, res) {
     const libraryItem = req.libraryItem
     const mediaPayload = req.body
 
     if (mediaPayload.url) {
       await LibraryItemController.prototype.uploadCover.bind(this)(req, res, false)
-      if (res.writableEnded) return
+      if (res.writableEnded || res.headersSent) return
     }
 
     // Book specific