Podcast endpoints #3140
Merged
Podcast endpoints #3140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, looks like there were not any merge conflicts. Assuming the previously mentioned validation issues are okay, this is good to merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues on from #3012.
This PR adds initial podcast endpoints and includes the
PodcastMetadata,PodcastEpisode, andPodcastschemas. More work is needed, but these routes and schemas are as accurate as I can make it with my current understanding of the data models and API. This future work will likely take place while working on LibraryItems and as some functions are updated.Each of the schemas has some failing validation, but I believe that is due to inconsistent data handling for podcasts when fetching new episode information from the internet or creating new podcast episodes. Specific examples are:
-Infwhich causes validation to fail even though it technically is an integer [Bug]:indexcolumn inpodcastEpisodestable always has-Infas value #3135)This PR will have merge conflicts with #3012, so once that PR is merged I can fix the bundled spec conflicts.
Next, I am planning to work on updating LibraryItems to include both book and podcast options.