Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
This PR adds a check for a non-null value for date-time fields in the web client to ensure
null
is not incorrectly submitted.Which issue is fixed?
Fixes #3775 and partially fixes #1519
In-depth Description
The submit button now checks that the date-time field to ensure that it is non-null. The datetime will be null if any field (day, month, year, hour, minute) is not set. I added a new error toast to inform the user of the date not being formatted correctly.
We could have the UI element default to 12:00 AM if only the time is not specified, such as is mentioned in #1519, as well as to ensure that different browsers render the "default" time correctly, such as Safari in #3775.
How have you tested this?
Tested the web client with fully valid datetimes, each individual field missing, and no change to the date.
Tested using Firefox.
Screenshots