Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trix to use paragraphs and break on return #3816

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented Jan 10, 2025

Brief summary

This fixes a couple of issues with the Trix text editor

In-depth Description

  • Trix translates p tags to div by default, and inserts redundant br tags on paragraph breaks. This fixes this.
  • Trix by default always puts a br tag on Enter, and never breaks a paragraph (there's literally no way to start a new paragraph). This changes the behavior to break paragraphs on Enter (you can still use Shfit+Enter for line breaks, like in other normal editors)

How have you tested this?

This was tested on various podcast episode descriptions in the Episode Details tab.

@mikiher mikiher marked this pull request as ready for review January 10, 2025 06:22
@advplyr
Copy link
Owner

advplyr commented Jan 10, 2025

Working great, thanks!

@advplyr advplyr merged commit c819afc into advplyr:master Jan 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants