Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing texture image & epub ebook url for subdirectory support #3864

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

mikiher
Copy link
Contributor

@mikiher mikiher commented Jan 20, 2025

Brief summary

Fixes a missing texture image in the nuxt build.

Which issue is fixed?

This addresses this comment in #385

Fixes #3865

In-depth Description

assets/app.css contained a direct url link to /textures/wood_default.jpg. This breaks subdirectory support. Changed this to ~static/textures/wood_default.jpg so it is picked and served by _nuxt (like other urls in the .css files)

How have you tested this?

Ran against a dev server. The texture image is now fetched successfully from /audiobookshelf/_nuxt/img/wood_default.6d366e7.jpg instead of /textures/wood_default.jpg.

@mikiher mikiher marked this pull request as ready for review January 20, 2025 06:58
@advplyr
Copy link
Owner

advplyr commented Jan 20, 2025

Looks like we missed adding base path to ebooks #3865

@advplyr
Copy link
Owner

advplyr commented Jan 20, 2025

We missed the get library request in store/libraries.js

https://discord.com/channels/942908292873723984/1006652923306066040/1330879198520283156

I'll be at my desk in an hour or so and can put these in just want to document

@advplyr
Copy link
Owner

advplyr commented Jan 20, 2025

That issue in discord may have to do with #3780 actually

@nichwall
Copy link
Contributor

That issue in discord may have to do with #3780 actually

If so, I think we can just roll back that PR to add case insensitivity to the path matching because it was just a CodeQL warning, and look at a resolution more later.

@advplyr
Copy link
Owner

advplyr commented Jan 20, 2025

Ah yeah I see why it happened now because some users have uppercase UUID's and when we lowercase the url the UUID no longer matches in queries.
Although I have no idea how they got an uppercase UUID

@advplyr advplyr changed the title Fix missing texture image for subdirectory support Fix missing texture image & epub ebook url for subdirectory support Jan 20, 2025
@advplyr
Copy link
Owner

advplyr commented Jan 20, 2025

The only other change for subdir support was to add the router base path to epub url because epub.js isn't using axios.
For the UUID issue I just reverted #3780

@advplyr advplyr merged commit f13283b into advplyr:master Jan 20, 2025
5 checks passed
@mikiher
Copy link
Contributor Author

mikiher commented Jan 20, 2025

Thanks for fixing the epub bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing subpath in ebook url
3 participants