Fix invalid date parsing on lemmy 0.18.4 (#723)

Resolves #616

Co-authored-by: Alexander Harding <[email protected]>

src/features/inbox/messages/Time.tsx

@@ -1,11 +1,12 @@
 import { differenceInDays, differenceInHours, format } from "date-fns";
+import { fixLemmyDateString } from "../../../helpers/date";
 
 interface TimeProps {
   date: string;
 }
 
 export default function Time({ date: dateStr }: TimeProps) {
-  const date = new Date(`${dateStr}Z`);
+  const date = new Date(fixLemmyDateString(dateStr));
 
   if (differenceInDays(new Date(), date) > 6) {
     return <>{format(date, "PP")}</>;

src/features/labels/Ago.tsx

@@ -1,4 +1,5 @@
 import { formatDistanceToNowStrict } from "date-fns";
+import { fixLemmyDateString } from "../../helpers/date";
 
 interface AgoProps {
   date: string;
@@ -10,9 +11,12 @@ export default function Ago({ date, className }: AgoProps) {
 }
 
 export function formatRelative(date: string): string {
-  const relativeDate = formatDistanceToNowStrict(new Date(`${date}Z`), {
-    addSuffix: false,
-  });
+  const relativeDate = formatDistanceToNowStrict(
+    new Date(fixLemmyDateString(date)),
+    {
+      addSuffix: false,
+    },
+  );
 
   return getRelativeDateString(relativeDate);
 }

src/features/labels/Edited.tsx

@@ -4,6 +4,7 @@ import { pencil } from "ionicons/icons";
 import { MouseEvent, useMemo } from "react";
 import { formatRelative } from "./Ago";
 import styled from "@emotion/styled";
+import { fixLemmyDateString } from "../../helpers/date";
 
 const Container = styled.div`
   display: flex;
@@ -46,7 +47,9 @@ export default function Edited({ item, showDate, className }: EditedProps) {
 
     present({
       header: `Edited ${formatRelative(edited)} Ago`,
-      message: `Last edited on ${new Date(`${edited}Z`).toLocaleTimeString()}`,
+      message: `Last edited on ${new Date(
+        fixLemmyDateString(edited),
+      ).toLocaleTimeString()}`,
       buttons: ["OK"],
     });
   }

src/features/user/Profile.tsx

@@ -21,6 +21,7 @@ import PostCommentFeed, {
   isPost,
 } from "../feed/PostCommentFeed";
 import { handleSelector, jwtSelector } from "../auth/authSlice";
+import { fixLemmyDateString } from "../../helpers/date";
 
 export const InsetIonItem = styled(IonItem)`
   --background: var(--ion-tab-bar-background, var(--ion-color-step-50, #fff));
@@ -118,6 +119,6 @@ export default function Profile({ person }: ProfileProps) {
 }
 
 function getCreatedDate(item: PostCommentItem): number {
-  if (isPost(item)) return Date.parse(`${item.post.published}Z`);
-  return Date.parse(`${item.comment.published}Z`);
+  if (isPost(item)) return Date.parse(fixLemmyDateString(item.post.published));
+  return Date.parse(fixLemmyDateString(item.comment.published));
 }

src/features/user/Scores.tsx

@@ -4,6 +4,7 @@ import { formatNumber } from "../../helpers/number";
 import Ago from "../labels/Ago";
 import { useIonAlert } from "@ionic/react";
 import { formatDistanceToNowStrict } from "date-fns";
+import { fixLemmyDateString } from "../../helpers/date";
 
 const Container = styled.div`
   display: flex;
@@ -35,7 +36,7 @@ export default function Scores({ aggregates, accountCreated }: ScoreProps) {
   const [present] = useIonAlert();
 
   const relativeDate = formatDistanceToNowStrict(
-    new Date(`${accountCreated}Z`),
+    new Date(fixLemmyDateString(accountCreated)),
     {
       addSuffix: false,
     },

src/helpers/date.ts

@@ -0,0 +1,11 @@
+/**
+ * Lemmy <= 0.18.3 has a bug where the Z isn't appended
+ *
+ * @param rawLemmyDateString Bugged lemmy date string
+ * @returns Consistent date string, ready to be passed to Date
+ */
+export function fixLemmyDateString(rawLemmyDateString: string): string {
+  if (rawLemmyDateString.endsWith("Z")) return rawLemmyDateString;
+
+  return `${rawLemmyDateString}Z`;
+}