-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support esbuild options #29
base: master
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,7 @@ | |||
# esbuild-jest | |||
|
|||
### A Jest transformer using esbuild | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier 🤦
} | ||
``` | ||
|
||
```js | ||
{ | ||
"transform": { | ||
"^.+\\.tsx?$": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prettier 🤦
loaders?: { | ||
[ext: string]: Loader; | ||
}; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actual change! ^^
...sourcemaps | ||
}) | ||
|
||
...esbuildOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 👀 👀 this is the "big" change. i'm really sorry about the big diff.
@cdaringe thanks for the PR, it would be good if you could add tests for this PR, to make sure it will not break. |
Ya, @silverwind , iirc it should. Feel free to pick up the PR. I hit a roadblock with esbuild, thus probably won't be pursuing this further |
Not really interested, sorry. I ended up writing my own jest transformer in place of this module (it's actually trivial) but am blocked by jest's ESM bugs currently to proceed. |
For anyone investigating: This approach is unlikely to be able to support build-only options like |
@aelbore |
Any updates regarding this one? This PR is what I need to fix some nasty bugs regarding numbered names. |
@adcorduneanu, @dst0, @bravely, @cdaringe |
Problem
Current implementation:
Solution
Discussion
yarn test
outside of CI yields:this is because the build step symlinks the dist folder. there's certainly ways around that, but FYI, I had to test like CI tests :)