Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option for jsx option to esbuild #86

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

breitembach
Copy link

  • Updated esbuild
  • hotifx automatic inject import React

@breitembach
Copy link
Author

import * as React from 'react'

is optional now

@@ -35,6 +35,7 @@ export interface Options {
},
target?: string
format?: string
jsx?: 'transform' | 'preserve' | 'automatic'
Copy link

@robwierzbowski robwierzbowski Apr 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly what I'm looking for. Thanks for this change, I'd love it to be reviewed by the project owner.

I would suggest that options be a pass through to avoid having to maintain the options object in the future.

@xphoenix
Copy link

xphoenix commented Oct 5, 2023

Could jsxImportSource also be added? Its crucial for use something like solid with automatic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants