This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
#[222] No info to user about invalid regex #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed html removed useless method
read error from log pass error to html
scalafmt
kamilongus
reviewed
Apr 6, 2019
kamilongus
reviewed
Apr 6, 2019
kamilongus
reviewed
Apr 6, 2019
kamilongus
reviewed
Apr 6, 2019
- fixed style-coding in html - added sealed trait for error message and change logic for it
- changes a little bit trait and case clasess
- added function and library to test regexp for validity - added error message about invalid regexp
- change first letter to capital - changed color
- scalafmt
kamilongus
reviewed
May 4, 2019
kamilongus
reviewed
May 4, 2019
| IO( | ||
| CSearchPage(Seq.empty[Search.PackageResult], | ||
| 0, | ||
| ErrorResponse(message.substring(0, 1).toUpperCase + message.substring(1, message.size)))) |
There was a problem hiding this comment.
Use .lenght instead .size on strings.
You can make a more elegant code without .substring concatination.
There was a problem hiding this comment.
Use .lenght instead .size on strings.
Does Scala have a linter that catches those things? (Also it's .length)
There was a problem hiding this comment.
@neongreen
Only IDE inspection support.
Or what did you mean?
There was a problem hiding this comment.
I meant a linter that we can run during CI.
I have just tried to run SonarQube on our code, but it didn't find the message.size thing :(
kamilongus
reviewed
May 4, 2019
kamilongus
reviewed
May 4, 2019
- added new trait for Error response - added new html for error response
# Conflicts: # core/src/main/scala/codesearch/core/search/Search.scala
- got some git problems, restore data in file
- scalafmt
kamilongus
reviewed
Jun 4, 2019
kamilongus
reviewed
Jun 4, 2019
|
@Kabowyad Please remove 62 row in |
- create function for creating errorResponse
- clean imports
- removed {}, because for some reasons it didn't compile
- scalafmt formating
- scalafmt formating (another one)
|
PR closed because it moved to another PR: #272 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.