aerogear-214 : Fixes IndexOutOfBounds issue #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pb82 was wondering if there's anyway to get someone to take a look at this |
|
@pb82 Could you pay attention to this? |
pb82
reviewed
Nov 7, 2024
| @@ -65,21 +65,23 @@ static String getResource(UriInfo uriInfo) { | |||
| static String getURI(UriInfo uriInfo) { | |||
| if (URI_METRICS_ENABLED) { | |||
| List<String> matchedURIs = uriInfo.getMatchedURIs(); | |||
| StringBuilder sb = new StringBuilder(); | |||
| if (!matchedURIs.isEmpty()) { | |||
There was a problem hiding this comment.
This makes sense. So previously we would try to access matchedURIs.get(0) even if there were no matched URIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes IndexOutOfBoundsException with keycloak 25 and keycloak-metrics-spi 6.0.0
Motivation
#214
What
Adding a check that
matchedURIsis not an empty list to ResourceExtractor.getURIWhy
Currently when using version keycloak-metrics-spi-6.0.0.jar with Keycloak 25 when a call comes into a URI that doesn't have a matching resource
uriInfo.getMatchedURIsreturns an empty list see https://jakarta.ee/specifications/platform/9/apidocs/jakarta/ws/rs/core/uriinfo#getMatchedURIs--How
Adding a check to ensure that
get(0)is not called on the empty listVerification Steps
Add the steps required to check this change. Following an example.
Checklist:
Progress
Additional Notes
PS.: Add images and/or .gifs to illustrate what was changed if this pull request modifies the appearance/output of something presented to the users.