Response Channels #1534

mikeb01 · 2023-11-16T03:57:26Z

This adds the ability to create pairs of request/response channels. Features include:

New control-mode (response) to configure the publication and subscription of the response side of the channel pair.
The ability to pass a response-correlation-id to indicate the association between a subscription and a publication for sending on the request channel and an image and a publication for sending on the response channel.
Adding the response-correlation-id to the criteria used to match publication when creating concurrent publications to prevent accidental sharing of request/response pairs.
Validation
The ability for multiple publications to share an underlying SendChannelEndpoint.

aeron-driver/src/main/java/io/aeron/driver/PendingSetupMessageFromSource.java

aeron-client/src/main/java/io/aeron/ChannelUriStringBuilder.java

aeron-samples/src/main/java/io/aeron/response/ResponseServer.java

aeron-client/src/main/java/io/aeron/protocol/ResponseSetupFlyweight.java

…ngBuilder and add initial parts of a system test.

…e same endpoint.

…ted.

…write some tests.

…ia when finding existing publications.

…orrelation-id on the request publication.

…hannel can be created.

…TS constants to Java definitions for completeness.

… setup message and constants.

…blication is not for a response channel.

…al validation to verify response-correlation-id uri parameters.

…come connected before they should. Make sure that response SubscriptionLinks that having been linked to a publication don't match.

…d to a publication don't match.

aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java

…nected response channels to prevent endpoints being closed at the wrong time.

…ting placeholder for the response stream.

…g placeholder for the response stream.

…so failure doesn't result in leaking resources.

github-advanced-security bot found potential problems Nov 16, 2023

View reviewed changes

mikeb01 force-pushed the feature/response_channels branch 4 times, most recently from 6850046 to 507c2ee Compare December 11, 2023 22:14

mikeb01 force-pushed the feature/response_channels branch from 507c2ee to 805bf4c Compare December 14, 2023 00:34

ethanf reviewed Dec 23, 2023

View reviewed changes

aeron-client/src/main/java/io/aeron/protocol/ResponseSetupFlyweight.java Outdated Show resolved Hide resolved

mikeb01 added 21 commits December 28, 2023 09:21

[Java] Initial work on response channels.

18067e3

[Java] Start adding more client based operations to the ClientUriStri…

bfc7bc5

…ngBuilder and add initial parts of a system test.

[Java] Partial implementation of handling multiple publications on th…

d384e73

…e same endpoint.

[Java] Use new ControlMode.RESPONSE to indicate response channels.

28520b9

[Java] Add test to cover multiple terms with response channels.

ced2cfa

[Java] Small tidy-ups and TODO comment.

3bbd82a

[Java] First basic implementation of connecting response channels.

90a7807

[Java] Stop sending RSP_SETUP message once response channel it connec…

a96f873

…ted.

[Java] Ensure that new subscription is only added once.

acb3de5

[Java] Remove println

9e37a82

[Java] Updating ResponseClient/Server.

483d6b0

[Java] Test showing that messages will come back to individual sessions.

9300eaa

[Java] Add additional validation for response channel settings and re…

db737d4

…write some tests.

[Java] Use the response correlation id as part of the matching criter…

cf00344

…ia when finding existing publications.

[Java] Check that the subscription exists when setting the response-c…

af4d1b1

…orrelation-id on the request publication.

[Java] Remove TODO.

eebb98e

[Java] Fix CodeQL issues.

060de88

[Java] Disable ResponseChannelsTest for C/C++ build.

4d09bd1

[Java] Test to show that multiple publications to the same response c…

8b4bc4d

…hannel can be created.

[Java] Update error message.

e2bf277

[Java] Change RSP_SETUP message type to allow for ATS messages. Add A…

941cc0f

…TS constants to Java definitions for completeness.

mikeb01 force-pushed the feature/response_channels branch from 805bf4c to 941cc0f Compare December 27, 2023 20:22

[C] Start adding C implementation for response channels. Add response…

debf879

… setup message and constants.

mikeb01 added 9 commits December 28, 2023 09:22

[C] More progress toward response channels.

7972647

[C] Additional error reporting. Only set SEND_RESPONSE_FLAG if the pu…

89df7f0

…blication is not for a response channel.

[C] Allow defaulting when parsing 64 bit uri parameters. Add addition…

0bc5b7e

…al validation to verify response-correlation-id uri parameters.

[Java] Fix checkstyle.

253ccf6

[Java] Add test to ensure that pending response subscription don't be…

663f325

…come connected before they should. Make sure that response SubscriptionLinks that having been linked to a publication don't match.

[C] Make sure that response SubscriptionLinks that haven't been linke…

6f56edb

…d to a publication don't match.

[Java] Start implementing dissector for RSP_SETUP frames.

ec0b453

[Java] Add dissector for RSP_SETUP frame.

47c1a8f

[C] Add dissector for RSP_SETUP frame.

b1cc283

vyazelenko reviewed Jan 4, 2024

View reviewed changes

aeron-driver/src/main/java/io/aeron/driver/PublicationImage.java Outdated Show resolved Hide resolved

mikeb01 added 10 commits January 10, 2024 09:17

[Java] Fix documentation.

ba5deb8

[Java] Remove double read of volatile and reverse elements of condition.

04ce545

[C] Remove debug logging.

202590a

[C] Remove test.

af8e3d5

[Java] Add reference tracking on the ReceiveChannelEndpoint for uncon…

91004ca

…nected response channels to prevent endpoints being closed at the wrong time.

[Java] Reverse order of adding connected response stream and decremen…

27e395d

…ting placeholder for the response stream.

[C] Reverse order of adding connected response stream and decrementin…

7621dcd

…g placeholder for the response stream.

[C] Resolve publication image before getting the network publication …

8731c44

…so failure doesn't result in leaking resources.

[C] Delete udp_channel on failure.

fe88326

[Java] Close session when removing in ResponseServer example.

3db5e74

mikeb01 merged commit faa2854 into aeron-io:master Jan 15, 2024
32 checks passed

mikeb01 deleted the feature/response_channels branch April 7, 2024 19:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Response Channels #1534

Response Channels #1534

mikeb01 commented Nov 16, 2023

Response Channels #1534

Response Channels #1534

Conversation

mikeb01 commented Nov 16, 2023