[java] optimize the logic of LogAdapter to determine whether the stream is closed. #1608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion more quickly, instead of waiting to detect the RecordingSignal.STOP signal in the slowTickWork method.
|
Unfortunately closing based on EOS in the consensus module could result in data not being completely written to the archive. By waiting until the Image has closed, means that the other subscription reading that image (i.e. the Archive) has also received the EOS and closed the recording. We feel that it is cleaner to allow the archive to complete the writing of the data it has received instead of closing early and relying on replication/catch up during the election process to back fill that data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this optimization is to quickly detect when the stream is closed, and then enter the election phase. In the scenario of leader.gracefulClose(), it shortens the time for cluster election.