Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TOOLS-2961 Warning should be based transaction_worker_threads and not on n_threads #102

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

a-spiker
Copy link
Contributor

@a-spiker a-spiker commented Sep 20, 2024

The Transaction workers considered at

uint32_t n_threads = args->n_threads;
which is transaction_workers + 1 [1 logging thread - 16 worker threads].
n_threads = 1 + cdata->transaction_worker_threads;

To fix the default warning of
WARN --keys is not divisible by (--batch-write-size * --threads) so more than --keys records will be written

setting the warning logic based on transaction_worker_threads and not using n_threads

@a-spiker
Copy link
Contributor Author

warning should be based on transaction_worker_threads and not on n_threads which is transaction_worker_threads + 1

@a-spiker a-spiker changed the title fix: TOOLS-2961 Set keys size for 17 Transaction Threads fix: TOOLS-2961 Warning should be based transaction_worker_threads and not on n_threads Sep 23, 2024
Copy link
Member

@sunilvirus sunilvirus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is better than the previous one.

Copy link
Contributor

@dwelch-spike dwelch-spike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@a-spiker a-spiker merged commit 47eeb17 into main Sep 24, 2024
8 checks passed
@a-spiker a-spiker deleted the tools-2961 branch September 24, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants