Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: null safe check for BatchWrite #396

Open
wants to merge 1 commit into
base: jdk8
Choose a base branch
from

Conversation

zsfVishnu
Copy link

  • The BatchWrite constructor which accepts an array of operations assumes no null values are present in the given array and accordingly performs dot operations on the individual elements within the class
    (eg for (Operation op : ops) { if (op.type.isWrite) { hasWrite = true; } size += Buffer.estimateSizeUtf8(op.binName) + Command.OPERATION_HEADER_SIZE; size += op.value.estimateSize(); } )
  • This causes a Null pointer exception.
  • Adding individual checks doesn't seem helpful since the same array might be passed down to other classes like BatchAttr, hence filtering at constructor level seems to make sense .
  • This PR is for jdk 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant