KO-348: Skip setting hostPort in Aerospike container for podOnly network and multiPodPerHost: false #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…multiPodPerHost: false
jwalantmodi05
requested review from
sud82,
tanmayja and
abhishekdwivedi3060
as code owners
sud82
requested changes
Oct 4, 2024
test/cluster/network_policy_test.go
Outdated
| @@ -708,6 +708,29 @@ func doTestNetworkPolicy( | |||
| }, | |||
| ) | |||
|
|
|||
| It("OnlyPodNetwork: should not set the hostport in pod only network"+ | |||
| "and multiPodPerHost is false", func() { | |||
There was a problem hiding this comment.
This line is not needed "and multiPodPerHost is false"
test/cluster/network_policy_test.go
Outdated
| ports := aerospikecluster.GetSTSContainerPort(aeroCluster.Spec.PodSpec.MultiPodPerHost, | ||
| aeroCluster.Spec.AerospikeConfig, &aeroCluster.Spec.AerospikeNetworkPolicy) | ||
|
|
||
| for _, port := range ports { |
There was a problem hiding this comment.
These are full integration tests. Therefore, you should try to deploy the cluster with podOnly network and then check if hostPort is exposed or not.
There was a problem hiding this comment.
No need to make GetSTSContainerPort public
abhishekdwivedi3060
force-pushed
the
KO-348
branch
from
2e50e37
to
58d3441
Compare
tanmayja
approved these changes
Oct 15, 2024
sud82
approved these changes
Oct 15, 2024
sud82
pushed a commit
that referenced
this pull request
Oct 16, 2024
* Fixed /config/apply API method for backup service * Added support for active-rack (#312) * Updated submodule to fetch 7.2 schemas * Changed order of recluster and set roster command in reconcile flow * Added duplicate volume name check in BackupService webhook * KO-348: Skip setting hostPort in Aerospike container for podOnly network and multiPodPerHost: false (#316) * Fixed tls and non-tls network policy hostPort flow * Fixed the setting of the error phase while the wrong server image is given. --------- Co-authored-by: Abhisek Dwivedi <[email protected]> Co-authored-by: Tanmay Jain <[email protected]> Co-authored-by: Jwalant Modi <[email protected]> Co-authored-by: Tanmay Jain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip setting hostPort in Aerospike container for podOnly network and multiPodPerHost: false