Skip to content

Commit

Permalink
remove pipeline mocks, rename NOOPProcessor to NoOpProcessor
Browse files Browse the repository at this point in the history
  • Loading branch information
dwelch-spike committed Feb 27, 2024
1 parent 22b6816 commit 6603d30
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 161 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@
go.work

# Generated files
mocks
mocks/
2 changes: 1 addition & 1 deletion backup_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ func (bh *backupHandler) run(writers []*WriteWorker[*models.Token]) error {

processorWorkers := make([]pipeline.Worker[*models.Token], bh.config.Parallel)
for i := 0; i < bh.config.Parallel; i++ {
processor := NewNOOPProcessor()
processor := NewNoOpProcessor()
processorWorkers[i] = NewProcessorWorker(processor)
}

Expand Down
148 changes: 0 additions & 148 deletions pipeline/mocks/Worker.go

This file was deleted.

16 changes: 7 additions & 9 deletions processors.go
Original file line number Diff line number Diff line change
Expand Up @@ -82,20 +82,18 @@ func (w *ProcessorWorker[T]) Run(ctx context.Context) error {
}
}

// **** NOOP Processor ****
// **** NoOp Processor ****

// NOOPProcessor satisfies the DataProcessor interface
// NoOpProcessor satisfies the DataProcessor interface
// It does nothing to the data
type NOOPProcessor struct{}
type NoOpProcessor struct{}

// NewNOOPProcessor creates a new NOOPProcessor
func NewNOOPProcessor() *NOOPProcessor {
return &NOOPProcessor{}
// NewNoOpProcessor creates a new NOOPProcessor
func NewNoOpProcessor() *NoOpProcessor {
return &NoOpProcessor{}
}

// Process processes the data
func (p *NOOPProcessor) Process(data *models.Token) (*models.Token, error) {
func (p *NoOpProcessor) Process(data *models.Token) (*models.Token, error) {
return data, nil
}

type NOOPProcessorFactory struct{}
2 changes: 1 addition & 1 deletion processors_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func (suite *proccessorTestSuite) TestProcessorWorkerProcessFailed() {
}

func (suite *proccessorTestSuite) TestNOOPProcessor() {
noop := NewNOOPProcessor()
noop := NewNoOpProcessor()
suite.NotNil(noop)

data := &models.Token{
Expand Down
2 changes: 1 addition & 1 deletion restore_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ func (rh *restoreHandler) run(readers []*ReadWorker[*models.Token]) error {

processorWorkers := make([]pipeline.Worker[*models.Token], rh.config.Parallel)
for i := 0; i < rh.config.Parallel; i++ {
processor := NewNOOPProcessor()
processor := NewNoOpProcessor()
processorWorkers[i] = NewProcessorWorker(processor)
}

Expand Down

0 comments on commit 6603d30

Please sign in to comment.