Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FMWK-658 Add retry mechanism to XDR info commands #207

Merged
merged 10 commits into from
Jan 28, 2025

Conversation

filkeith
Copy link
Contributor

  • retry for stop xdr and unblock mrt commands

- retry for stop xdr and unblock mrt commands
@filkeith filkeith requested a review from reugn January 27, 2025 08:30
cmd/internal/flags/backup_xdr.go Outdated Show resolved Hide resolved
cmd/internal/models/backup_xdr.go Outdated Show resolved Hide resolved
@reugn reugn changed the title FMWK-658 Retry info commands FMWK-658 Add retry mechanism to XDR info commands Jan 27, 2025
@filkeith filkeith requested a review from reugn January 28, 2025 09:02
@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 70.08929% with 67 lines in your changes missing coverage. Please review.

Project coverage is 78.35%. Comparing base (7b1c6ba) to head (0c47fbc).

Files with missing lines Patch % Lines
internal/asinfo/info_client.go 74.59% 21 Missing and 10 partials ⚠️
cmd/internal/app/asbackup.go 0.00% 25 Missing ⚠️
cmd/internal/app/validation.go 78.78% 5 Missing and 2 partials ⚠️
handler_backup_xdr.go 62.50% 2 Missing and 1 partial ⚠️
cmd/internal/app/reports.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           xdr-support     #207      +/-   ##
===============================================
+ Coverage        78.10%   78.35%   +0.25%     
===============================================
  Files              109      109              
  Lines             9838     9975     +137     
===============================================
+ Hits              7684     7816     +132     
- Misses            1651     1653       +2     
- Partials           503      506       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

cmd/internal/app/validation.go Outdated Show resolved Hide resolved
cmd/internal/flags/backup.go Show resolved Hide resolved
cmd/internal/flags/backup.go Outdated Show resolved Hide resolved
cmd/internal/flags/backup_xdr.go Show resolved Hide resolved
models/retry_policy.go Outdated Show resolved Hide resolved
cmd/internal/app/asbackup.go Outdated Show resolved Hide resolved
cmd/internal/app/asbackup.go Outdated Show resolved Hide resolved
@filkeith filkeith requested a review from reugn January 28, 2025 10:11
@filkeith filkeith merged commit fcff047 into xdr-support Jan 28, 2025
4 checks passed
@filkeith filkeith deleted the FMWK-658-retry-info-commands branch January 28, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants