Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-23 | Added Scheduler to Remove Expired Tokens #254

Merged
merged 8 commits into from
Dec 31, 2023

Conversation

thelastbadalov
Copy link
Contributor

@thelastbadalov thelastbadalov commented Nov 19, 2023

Description

in this pr i did clear invalid token table with cron job.

Related Issue

#253

Proposed Changes

Please provide a brief and descriptive title for your pull request, summarizing the changes or features introduced. It
should be in English and clearly indicate the purpose of the pull request. Optionally, you can provide a more detailed
description of what you have done.

  • Branches should follow the below Naming Conventions of Branchs header in README.md File

Additional Information

If there's any additional information or context that the reviewers should know, please provide it here.

Checklist

Please check the following before submitting your pull request:

  • I have tested my changes locally and they are working as expected.
  • The code is formatted according to the project's coding guidelines and style.
  • Necessary documentation has been added or existing documentation has been updated.
  • Relevant unit tests have been written and included.
  • Relevant integration tests have been written and included.
  • The code has been reviewed to ensure its quality.
  • The code does not contain any issues flagged by SonarLint.
  • Default reviewers have been assigned to this pull request.
  • Assignees have been added if necessary.
  • Labels have been applied if necessary.
  • If an issue is opened and this pull request is related to that issue, it should not be associated with any project
    board or milestone. However, if there is no issue, the pull request should be associated with the appropriate project
    board (BE Board, In Review column) and milestone to track the progress.

Reviewers

The default project maintainers and team members will be automatically assigned as reviewers for this pull request.

@agitrubard
Copy link
Collaborator

@thelastbadalov Selam,
Pull request başlığını bizim standartlarımıza göre düzenlemen gerekiyor. Ek olarak template-settings.xml dosyasını sildiğin için pipeline'da hata vermiş gibi duruyor bunu da geri almak gerekiyor.

Copy link
Contributor

@AhmetAksunger AhmetAksunger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selamlar, DatabaseClearSchedulerService'in veya güncellenecek ismiyle UnusedInvalidTokenDeletionScheduler sınıfının unit testlerini de yazabilir miyiz?

@agitrubard agitrubard marked this pull request as draft November 23, 2023 18:22
@ibrahimdenizz ibrahimdenizz changed the title Feature/253/scheduled db clear #253 | Added Scheduler to Remove Expired Tokens Dec 4, 2023
@ibrahimdenizz ibrahimdenizz linked an issue Dec 4, 2023 that may be closed by this pull request
@ibrahimdenizz ibrahimdenizz marked this pull request as ready for review December 4, 2023 19:54
anilhazar
anilhazar previously approved these changes Dec 5, 2023
@agitrubard agitrubard changed the title #253 | Added Scheduler to Remove Expired Tokens AYS-23 | Added Scheduler to Remove Expired Tokens Dec 20, 2023
@agitrubard agitrubard merged commit bde4f77 into main Dec 31, 2023
1 check passed
@agitrubard agitrubard deleted the feature/253/scheduled-db-clear branch December 31, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AYS_INVALID_TOKEN Tablosunun Belli Aralıklarla Temizlenmesi
6 participants