Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-555 | Refactored "ALREADY EXIST" errors to standardize as "CONFLICT ERROR" #417

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

gunesakkayaa
Copy link
Contributor

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

@agitrubard
Copy link
Collaborator

agitrubard commented Dec 21, 2024

Selamlar @gunesakkayaa,

  • Pull requestin başlığını var olan standartlarımıza göre güncellememiz gerekiyor. Detaylar checklist'te yazıyor.
  • Bu branch için önemli değil ama bir sonrakiler için issue'nun tipine göre branch'teki prefix'i belirleyebilirsek çok daha iyi olabilir. Yani biz şu an bugfix değil refactor yaptık ✅
  • Reviewer kısmına @afet-yonetim-sistemi/back-end ve @afetyonetimsistemi hesaplarını eklememeye çalışalım. Sadece kişileri eklesek yeterli ✅

@gunesakkayaa gunesakkayaa changed the title AYS-555 | ALREADY EXIST UPDATED AS CONFLICT ERROR AYS-555 | Already exist updated as conflict error Dec 21, 2024
@gunesakkayaa gunesakkayaa changed the title AYS-555 | Already exist updated as conflict error AYS-555 | Refactored "ALREADY EXIST" errors to standardize as "CONFLICT ERROR" Dec 21, 2024
@agitrubard agitrubard requested a review from sarpkan00 December 21, 2024 12:07
@agitrubard agitrubard merged commit d556f9a into main Dec 21, 2024
3 checks passed
@agitrubard agitrubard deleted the bugfix/AYS-555/already-exist-updated-as-conflict branch December 21, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants