Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AYS-602 | Blank Check Added to EmergencyEvacuationApp to Validate Source & Target City/District Difference #429

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

mgemicio
Copy link
Contributor

Checklist

Before submitting your pull request, ensure the following:

  • Title and Branch Naming Conventions:

  • Local Testing:

    • I have tested my changes locally on Postman, and they are working as expected.
  • Code Quality:

    • The code is formatted according to the project's coding guidelines and style.
    • The code has been reviewed to ensure its quality.
    • The code does not contain any issues flagged by SonarLint.
  • Documentation:

    • Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
  • Testing:

    • Relevant unit tests have been written and included.
    • Relevant integration tests have been written and included.
  • Reviewers and Assignees:

    • Default reviewers have been assigned to this pull request.
    • Assignees have been added if necessary.
  • Labels and Associations:

    • No specific actions are required in the Labels and Associations section for this pull request.

Copy link
Contributor

@idilalemdar idilalemdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link
Contributor

@idilalemdar idilalemdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agitrubard ile aynı parametrized test talebim var, bunun dışında bir değişikliğe gerek görmüyorum, ellerine sağlık @mgemicio

@agitrubard
Copy link
Collaborator

@mgemicio conflict mevcut

…ank-city-and-district

# Conflicts:
#	src/main/java/org/ays/emergency_application/model/request/EmergencyEvacuationApplicationRequest.java
@agitrubard agitrubard merged commit e0207f3 into main Jan 29, 2025
1 check passed
@agitrubard agitrubard deleted the bugfix/AYS-602/fix-blank-city-and-district branch January 29, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants