Make ctrl+x/c/v/s work on linux and macOS #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need this PR to be merged before doing the undo position/rotation/scale PR @dmarcos |
…x/c/v/s to work on macos
vincentfretin
changed the title
|
Actually it didn't work either on macOS because of metaKey check in shouldCaptureKeyEvent. I checked with @kfarr for macOS for all the shortcuts here, we don't see why there was the metaKey check in shouldCaptureKeyEvent here. We just know the implementation was initially copied from AFRAME.utils.shouldCaptureKeyEvent that is used mainly for wasd-controls, but even for this I'm not sure why we need to check for metaKey (cmd key on macOS). |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also use ctrl key on Ubuntu, not just Windows ;)
Those are the shortcuts to cut, copy, paste an entity and focus the search input.