Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[text] Add .negate property for msdfgen >1.4 #3383

Merged
merged 1 commit into from
Feb 10, 2018
Merged

[text] Add .negate property for msdfgen >1.4 #3383

merged 1 commit into from
Feb 10, 2018

Conversation

donmccurdy
Copy link
Member

Fixes #3382.

Testing with fonts created here: http://msdf-bmfont.donmccurdy.com/

text="align: center; width: 6;
    font: /examples/assets/fonts/yahei.json;
    value: 你好,世界;
    negate: false;
    shader: msdf;"

screen shot 2018-02-09 at 11 12 25 pm

@dmarcos
Copy link
Member

dmarcos commented Feb 10, 2018

Thanks!

@dmarcos dmarcos merged commit 5f4179d into aframevr:master Feb 10, 2018
@machenmusik
Copy link
Contributor

Nice! Maybe we should regenerate the older default font with the new tool, and default negate to false (at least for msdf) so all new msdf fonts we create will work without the flag?

@donmccurdy donmccurdy deleted the feat-msdf-1.4 branch February 10, 2018 17:45
@donmccurdy
Copy link
Member Author

donmccurdy commented Feb 10, 2018

The fonts in aframe-fonts would need to be updated too, they are generated from https://github.com/Jam3/msdf-bmfont, which is still using the old msdfgen version. Users reporting issues because of that: etiennepinchon/aframe-fonts#1 (comment)

I'm hoping my little web app can help out here, and let you generate just the character set you need (especially necessary for chinese users), but i need to iron out some issues first. So, probably won't want to change the default for 0.8.0 I don't think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants