support for vscode themes #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is incredible, thank you! I'll give it a look asap and would love to push this live. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I often work with light themes when working in bright environments like the outside and noticed, that Depot has some hardcoded color values. So I tried to make it as much compatible with custom themes as possible. This involved changing a few ways how the table is drawn to be more in line with Visual Studio Codes UI style (mainly borders and the tabs)
231028_VsCodeThemes_01.mp4
The sheet selction buttons are now in line with how Visual Studio Code renders Tabs
231028_VsCodeThemes_02.mp4
I also made sure the sheet headers stay pinned to the top of the screen when scrolling down long lists
231028_VsCodeThemes_03.mp4