Pass optional and extras specification to rewritten dependencies #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @H0R5E, Thanks for contributing, this is a very useful addition! I had a quick look, and everything looks good. I'll test it out locally later as well to be sure and I will approve it then |
ag14774
approved these changes
Dec 18, 2024
|
I will release this at the latest tomorrow |
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks very much for developing this plugin. The shared lock file is precisely what I need for the monorepo I am working on (https://github.com/DTOcean/dtocean/tree/next).
I would like to be able to include some path dependencies as extras and those dependencies might also require their own dependency extras to be defined.
This PR, then, copies the
optionalandextrasconfiguration to the rewritten dependencies.