Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Cable Damage Update #6

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

OmegaHaxors
Copy link
Contributor

Revamped the way cables damage entities.
Cables no longer hurt non-living creatures.
Touching a cable will hurt a lot and send you flying backwards.
Creepers shocked by cables will explode

Revamped the way cables damage entities.
Cables no longer hurt non-living creatures.
Touching a cable will hurt a lot and send you flying backwards.
Creepers shocked by cables will explode
Copy link
Collaborator

@jrddunbr jrddunbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor stuff. That distance to method in utils needs reviewing as to where it is used and how. It looks like it was a basic function which needs to be reconsidered for efficiency. Doing square roots is expensive though, so avoid that if possible.

src/main/java/org/ja13/eau/EAU.java Outdated Show resolved Hide resolved
src/main/java/org/ja13/eau/misc/Coordonate.kt Outdated Show resolved Hide resolved
ready for pulling
Now with custom kill message
Adds a ton of new armors, the alloys Bronze and Electrum, and Silver Ingots
This reverts commit df1653a.
Copper Armor no longer errendiously uses "iron" as its build material. Now it will use the stats of Leather Armor (because it is a very easy set to make) and, get this, can be repaired with Copper ingots.
Copy link
Collaborator

@jrddunbr jrddunbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some stuff that isn't quite there. I'm concerned about the performance of the player harmer functionality causing TPS problems.

Optimized code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants