This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Cable Damage Update #6
Open
OmegaHaxors
wants to merge
8
commits into
age-series:main
Choose a base branch
from
OmegaHaxors:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revamped the way cables damage entities. Cables no longer hurt non-living creatures. Touching a cable will hurt a lot and send you flying backwards. Creepers shocked by cables will explode
jrddunbr
suggested changes
Nov 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor stuff. That distance to method in utils needs reviewing as to where it is used and how. It looks like it was a basic function which needs to be reconsidered for efficiency. Doing square roots is expensive though, so avoid that if possible.
src/main/java/org/ja13/eau/sixnode/electriccable/ElectricCable.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/ja13/eau/sixnode/electriccable/ElectricCable.kt
Outdated
Show resolved
Hide resolved
ready for pulling
Now with custom kill message
Adds a ton of new armors, the alloys Bronze and Electrum, and Silver Ingots
This reverts commit df1653a.
Copper Armor no longer errendiously uses "iron" as its build material. Now it will use the stats of Leather Armor (because it is a very easy set to make) and, get this, can be repaired with Copper ingots.
jrddunbr
suggested changes
Nov 6, 2020
src/main/java/org/ja13/eau/sixnode/electriccable/ElectricCable.kt
Outdated
Show resolved
Hide resolved
src/main/java/org/ja13/eau/sixnode/electriccable/ElectricCable.kt
Outdated
Show resolved
Hide resolved
jrddunbr
suggested changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some stuff that isn't quite there. I'm concerned about the performance of the player harmer functionality causing TPS problems.
Optimized code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamped the way cables damage entities.
Cables no longer hurt non-living creatures.
Touching a cable will hurt a lot and send you flying backwards.
Creepers shocked by cables will explode