Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little 32x upscaling #266

Open
wants to merge 11 commits into
base: 1.19.x
Choose a base branch
from

Conversation

DarthSidiousPalpatine
Copy link
Contributor

@DarthSidiousPalpatine DarthSidiousPalpatine commented Dec 23, 2022

To match previously added items:
image
82 items got an upscaled version. Plus lightbulbs now differentiate from each other:
image
image

A bit outdated, but i'll try to improve some of them later.

Its added in 4 commits:
Lightbulbs, Cables, Tools, Components, Resources so you can reject any "pack" by your wish, idk.

Copy link
Collaborator

@jrddunbr jrddunbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, please make sure everything's centered in their box. Looks like many items are not centered.

  • Motor: Can we get a 3rd wire on the advanced motor and make it look more like a bipolar stepper?
  • Magnets: Too hard to tell apart. Only the advanced one is used so I might change that one to being a neodymium or something (ditching the "advanced" name in the process) in the future, and make the old one stay a magnetized iron core like it is in your current basic magnet texture.
  • Batteries: I like the old colors better. The cylinders look a little weird
  • Dusts: The bottom of the dust looks a little weird; can we pull the bottom a bit more flat?

@DarthSidiousPalpatine
Copy link
Contributor Author

Ok, a tweak:
image
image

@DarthSidiousPalpatine
Copy link
Contributor Author

advancedelectricalmotor
ok, a motor

@DarthSidiousPalpatine
Copy link
Contributor Author

Hmm, seems like i forgot about magnets.
And why transistor.png seems conflicting?

@jrddunbr
Copy link
Collaborator

Needs to be rebased against 1.20.x. Not sure why there's a conflict with the transistor but it may be related to a git command you used.

@jrddunbr
Copy link
Collaborator

Needs to be rebased on 1.21.x

@jrddunbr
Copy link
Collaborator

Needs to be rebased on 1.22.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants