Fix typo #90
Merged
Fix typo #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -331,7 +331,7 @@ The constructor takes many keyword arguments that will affect its behavior. | |||
| * ``vhost`` Default "/". | |||
| * ``connect_timeout`` Default 5 seconds. Time before socket connection fails. | |||
| * ``sock_opts`` Default None. Recommend at least ``{(socket.IPPROTO_TCP, socket.TCP_NODELAY) : 1}`` | |||
| * ``hearbeat`` Default None (disabled). If 0, broker assigned. If >0, negotiated with broker. | |||
| * ``heartbeat`` Default None (disabled). If 0, broker assigned. If >0, negotiated with broker. | |||
There was a problem hiding this comment.
@awestendorf: I just noticed that the description doesn't match the implementation. The implementation appears to be that if user passed heartbeat=None, then the heartbeat value is broker-assigned; if user passed heartbeat=0, then heartbeats would be disabled. The description is the reverse of what actually happens.
if self.connection._heartbeat is None:
self.connection._heartbeat = method_frame.args.read_short()
I filed this as issue #91
josegonzalez
added a commit
to josegonzalez/haigha
that referenced
this pull request
Feb 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.