Skip to content

Commit

Permalink
ci(lint): make tolerant of deprecations
Browse files Browse the repository at this point in the history
  • Loading branch information
michaelfig committed Aug 3, 2024
1 parent 3768f9c commit c8d22ea
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ jobs:
golangci:
name: golangci-lint
runs-on: ubuntu-latest
strategy:
matrix:
mode: [no-failure, no-deprecations]
steps:
- uses: actions/setup-go@v3
with:
Expand All @@ -24,3 +27,6 @@ jobs:
with:
# Optional: version of golangci-lint to use in form of v1.2 or v1.2.3 or `latest` to use the latest version
version: v1.49.0
args:
${{ matrix.mode == 'no-deprecations' && '--exclude=^SA1019' || '' }}
${{ matrix.mode == 'no-failure' && '--issues-exit-code=0' || '' }}
2 changes: 1 addition & 1 deletion crypto/keyring/keyring.go
Original file line number Diff line number Diff line change
Expand Up @@ -719,7 +719,7 @@ func newRealPrompt(dir string, buf io.Reader) func(string) (string, error) {
continue
}

// nolint:gosec // ignore gosec G306: Expect WriteFile permissions to be 0600 or less
// [AGORIC] unused for linter "gosec" // nolint:gosec // ignore gosec G306: Expect WriteFile permissions to be 0600 or less
if err := os.WriteFile(dir+"/keyhash", passwordHash, 0o555); err != nil {
return "", err
}
Expand Down

0 comments on commit c8d22ea

Please sign in to comment.