-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: have tx gov submit-proposal accept either new or legacy syntax #378
Conversation
Have submit-legacy-proposal be an alias for submit-proposal. Invocations of the legacy syntax should either upgrade to the new syntax, or explicitly use submit-legacy-proposal. When all legacy usages have so migrated, this change can be dropped. See Agoric/agoric-sdk#8871.
No new tests since this is meant to be backward-compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would take me a while to study this enough to give an "I understand this well enough to help maintain it" review.
If there's some urgency and an "I don't see any problems" approval is useful, LMK.
The golangci-lint failure is expected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Well done.
Have submit-legacy-proposal be an alias for submit-proposal. Invocations of the legacy syntax should either upgrade to the new syntax, or explicitly use submit-legacy-proposal. When all legacy usages have so migrated, this change can be dropped. See Agoric/agoric-sdk#8871.
Description
Refs: cosmos#8871
Alter the
tx gov submit-proposal
command so that it works either with the new or legacy syntax, and also alias it assubmit-legacy-proposal
. Users of the legacy command will continue to work as-is, but over time they should either explicitly usesubmit-legacy-proposal
, or upgrade to the new syntax. When all call sites have done one or the other of these choices, we can drop our modification to this command.The slight limitation of this approach is that you cannot name the new-syntax JSON file the same as one of the legacy subcommands.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change