Add the network marker to some tests that need DNS #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing in Fedora Linux (building distribution packages in an offline environment) shows that – even though they might not require Internet access – the following test classes require at least DNS, and fail in a fully offline environment:
TestConnectedUDPSocketTestTCPListenerTestUDPSocket(excepttest_create_unbound_socket)This PR adds the
networkmark to each of the test classes listed above. (I chose to mark the entireTestUDPSocketclass rather than trying to mark every method excepttest_create_unbound_socket.)