WIP: Switch default Debian branch to 'debian/latest' (Closes: #829444) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Salsa-CI running at https://salsa.debian.org/otto/git-buildpackage/-/pipelines |
|
I understand the tests and the However, this is far from complete. As discussed in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829444#45 we need to figure out how to detect new repositories and only apply the default new branch name |
As defined by DEP14, the default Debian packaging branch name should be 'debian/latest' instead of 'master. https://dep-team.pages.debian.net/deps/dep14/
======================================================================
FAIL: Dump the repository and check if files exist
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/nose/case.py", line 197, in runTest
self.test(*self.arg)
File "/builds/otto/git-buildpackage/debian/output/source_dir/tests/04_test_submodules.py", line 116, in test_dump_tree
ok_(buildpackage.dump_tree(REPO, dumpdir, "debian/latest", True))
AssertionError: None
-------------------- >> begin captured logging << --------------------
gbp: error: Error in dump_tree archive pipe
--------------------- >> end captured logging << ---------------------
======================================================================
FAIL: test_30_quilt (tests.24_test_gbp_import_orig.TestIs30Quilt.test_30_quilt)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/builds/otto/git-buildpackage/debian/output/source_dir/tests/24_test_gbp_import_orig.py", line 55, in test_30_quilt
self.assertEquals(self.repo.branch, options.debian_branch)
AssertionError: 'master' != 'debian/latest'
- master
+ debian/latest
======================================================================
FAIL: Make sure we shorten the reflog entry properly
----------------------------------------------------------------------
Traceback (most recent call last):
File "/builds/otto/git-buildpackage/debian/output/source_dir/tests/28_test_gbp_git_repository_commit_dir.py", line 41, in test_long_msg_854333
self.assertEquals(ret, 0)
AssertionError: 128 != 0
…tRepo'" This reverts commit 2fef23b0bde35d2896d955c4a0e7dd865474a4b3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As defined by DEP14, the default Debian packaging branch name should be 'debian/latest' instead of 'master.
https://dep-team.pages.debian.net/deps/dep14/
Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829444