Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KTP-47] Basic Front End For Course Contents Page (Student View) #27

Merged
merged 23 commits into from
Dec 18, 2024

Conversation

ahmedyoussefg
Copy link
Owner

@ahmedyoussefg ahmedyoussefg commented Dec 16, 2024

I need review for work till now

Key remaining tasks (needed for merge)

  • Change videoUrl to content
  • Mark as Completed for Lesson
  • Progress Bar
  • Write API endpoints

Other possible tasks:

- [ ] Refactor code
- [ ] Test written code
- [ ] Style it better

Copy link

github-actions bot commented Dec 16, 2024

Code Coverage Summary

Overall Project 77.39% 🍏

There is no coverage information present for the Files changed

@ahmedyoussefg ahmedyoussefg force-pushed the ktp-47-student-course-page branch 2 times, most recently from 98b9b60 to b0c1318 Compare December 16, 2024 19:01
@ahmedyoussefg ahmedyoussefg force-pushed the ktp-47-student-course-page branch from b0c1318 to c134197 Compare December 16, 2024 19:05
@ahmedyoussefg
Copy link
Owner Author

@asserelzeki6, the Lesson will have content and isCompleted attributes and won't have videoUrl.

asserelzeki6

This comment was marked as resolved.

@ahmedyoussefg
Copy link
Owner Author

you can use here the fetchData() function from api.js that fetches data by taking the param to the endpoint and also takes the DTO that maps the response to that DTO. We can agree afterwards about the endpoint but for now make it '/course/content'

OK I'll keep that in mind while we start integrating with backend

TODO: fix the button and make it posts an API call to backend
@ahmedyoussefg
Copy link
Owner Author

ahmedyoussefg commented Dec 17, 2024

Updates: (Remaining Main TODOs)

  • 'Mark as Completed for Lesson,' has a part I need to fix where I'm sending the content as a string, so I will have to send the whole lesson object. I haven't implemented the API endpoint for it yet.
  • also the API endpoint for course/content is not implemented yet.
    @asserelzeki6

@ahmedyoussefg ahmedyoussefg changed the title [KTP-47] [In progress] Basic Front End For Course Contents Page (Student View) [KTP-47] Basic Front End For Course Contents Page (Student View) Dec 17, 2024
@ahmedyoussefg ahmedyoussefg merged commit 96598a4 into devel Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants